-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh/dixon #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
are we attached to julia versions <1.3 ? these do not allow attaching methods to abstract types and we need the following (rather ugly): if VERSION >= v"1.3.0"
function (χ::AbstractClassFunction)(g::PermutationGroups.AbstractPerm)
for (i, cc) in enumerate(conjugacy_classes(χ))
g ∈ cc && return χ[i]
end
throw(DomainError(g, "element does not belong to conjugacy classes of χ"))
end
else
function (χ::Character)(g::PermutationGroups.AbstractPerm)
for (i, cc) in enumerate(conjugacy_classes(χ))
g ∈ cc && return χ[i]
end
throw(DomainError(g, "element does not belong to conjugacy classes of χ"))
end
end |
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 77.72% 86.52% +8.80%
==========================================
Files 6 7 +1
Lines 202 282 +80
==========================================
+ Hits 157 244 +87
+ Misses 45 38 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
looks good to me ;-) |
there is a lot of stuff here, but we need to wait for the recent versions of Cyclotomics and PermutationGroups anyway
TLDR: